[MINOR] CLI error handling on streaming use cases#8761
Merged
alamb merged 1 commit intoapache:mainfrom Jan 5, 2024
synnada-ai:bug/streaming-cli-error-prob
Merged
[MINOR] CLI error handling on streaming use cases#8761alamb merged 1 commit intoapache:mainfrom synnada-ai:bug/streaming-cli-error-prob
alamb merged 1 commit intoapache:mainfrom
synnada-ai:bug/streaming-cli-error-prob
Conversation
9 tasks
alamb
approved these changes
Jan 5, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- thanks @metesynnada
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
If a streaming execution sends an error, the loop finishes as no error was received, thus this was a bug.
What changes are included in this PR?
Handling the error if the stream sends an error.
Are these changes tested?
Yes
Are there any user-facing changes?
Improved error handling.