[MINOR]: Add a test case for when target partition is 1, no hash repartition is added to the plan.#8757
Merged
mustafasrepo merged 1 commit intoapache:mainfrom Jan 5, 2024
synnada-ai:minor/target1_hash_repartition
Merged
[MINOR]: Add a test case for when target partition is 1, no hash repartition is added to the plan.#8757mustafasrepo merged 1 commit intoapache:mainfrom synnada-ai:minor/target1_hash_repartition
mustafasrepo merged 1 commit intoapache:mainfrom
synnada-ai:minor/target1_hash_repartition
Conversation
github-actions
Bot
added
core
mustafasrepo
commented
Jan 5, 2024
| ) -> Result<DistributionContext> { | ||
| let partition_count = input.plan.output_partitioning().partition_count(); | ||
| // Early return if hash repartition is unnecessary | ||
| if n_target == partition_count && n_target == 1 { |
Contributor
Author
There was a problem hiding this comment.
I think previous check was wrong, partition count equality doesn't mean their hash requirement is satisfied. However, when target is 1 hash requirement is trivially satisfied
ozankabak
approved these changes
Jan 5, 2024
Contributor
ozankabak
left a comment
ozankabak
left a comment
There was a problem hiding this comment.
LGTM, but I'd appreciate a quick look by @Dandandan or @alamb
Dandandan
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?