Add support for functional dependency for ROW_NUMBER window function.#8737
Merged
ozankabak merged 4 commits intoapache:mainfrom Jan 4, 2024
synnada-ai:feature/row_number_pk
Merged
Add support for functional dependency for ROW_NUMBER window function.#8737ozankabak merged 4 commits intoapache:mainfrom synnada-ai:feature/row_number_pk
ozankabak merged 4 commits intoapache:mainfrom
synnada-ai:feature/row_number_pk
Conversation
ozankabak
approved these changes
Jan 3, 2024
Contributor
ozankabak
left a comment
There was a problem hiding this comment.
Simple and straightforward, LGTM
Contributor
|
I will go ahead and merge this since it is a very simple change. In case I'm not seeing some possible issue related to this, we will promptly fix with a follow-on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
For window queries in the form
ROW_NUMBER() OVER(PARTITION BY <empty> ORDER BY <expr>), we know that row numbers generated will consists of consecutive numbers across table. Hence result of this expression can be treated asPRIMARY_KEY. This enables us to execute queries in the form belowwithout this support query above should be re-written as
to be able to execute.
What changes are included in this PR?
This PR adds ROW_NUMBER result as functional dependencies when it known that its result will be unique across rows (when partition by expression is empty).
Are these changes tested?
Yes
Are there any user-facing changes?