[minor]: Fix rank calculation bug when empty order by is seen#8567
Merged
alamb merged 3 commits intoapache:mainfrom Dec 18, 2023
synnada-ai:bug_fix/empty_rank
Merged
[minor]: Fix rank calculation bug when empty order by is seen#8567alamb merged 3 commits intoapache:mainfrom synnada-ai:bug_fix/empty_rank
alamb merged 3 commits intoapache:mainfrom
synnada-ai:bug_fix/empty_rank
Conversation
github-actions
Bot
added
sql
Contributor
Author
|
Thanks @comphead for discovering this bug. |
# Conflicts: # datafusion/sql/src/expr/function.rs # datafusion/sqllogictest/test_files/window.slt
comphead
approved these changes
Dec 18, 2023
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @mustafasrepo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Builds on commits in PR8559 (That PR should be merged first). Fixes bug described in discussion.
What changes are included in this PR?
Current rank function produces wrong results when there is no expression in the order by clause. This PR fixes this bug.
Are these changes tested?
Yes
Are there any user-facing changes?