Skip to content

[MINOR]: Add getter methods to first and last value#8555

Merged
metesynnada merged 1 commit intoapache:mainfrom
synnada-ai:minor/add_getters_to_first_last
Dec 15, 2023
Merged

[MINOR]: Add getter methods to first and last value#8555
metesynnada merged 1 commit intoapache:mainfrom
synnada-ai:minor/add_getters_to_first_last

Conversation

@mustafasrepo
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

I will be useful to reach private members from another files.

What changes are included in this PR?

This PR adds getter methods for FIRST_VALUE and LAST_VALUE aggregate functions.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added the physical-expr Changes to the physical-expr crates label Dec 15, 2023
Copy link
Copy Markdown
Contributor

@metesynnada metesynnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants