Remove order_bys from AggregateExec state#8537
Merged
Dandandan merged 2 commits intoapache:mainfrom Dec 14, 2023
synnada-ai:feature/rem_order_from_aggregate_args
Merged
Remove order_bys from AggregateExec state#8537Dandandan merged 2 commits intoapache:mainfrom synnada-ai:feature/rem_order_from_aggregate_args
Dandandan merged 2 commits intoapache:mainfrom
synnada-ai:feature/rem_order_from_aggregate_args
Conversation
8 tasks
alamb
approved these changes
Dec 14, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I agree this looks like a nice cleanup to me. Thank you @mustafasrepo
| let original_schema = Arc::new(original_schema); | ||
| // Reset ordering requirement to `None` if aggregator is not order-sensitive | ||
| order_by_expr = aggr_expr | ||
| let mut order_by_expr = aggr_expr |
Contributor
There was a problem hiding this comment.
This is the key observation, right? That the ordering can be derived from the AggregateExprs themselves
Dandandan
approved these changes
Dec 14, 2023
Contributor
|
Nice, thank you @mustafasrepo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
While working on another PR, I realized that
Arc<dyn AggregateExpr>hasorder_bymethod, and keeps its requirement in its state. Hence, I thinkorder_bysmember which keeps requirement of each aggregate expression is redundant.What changes are included in this PR?
This PR removes
order_bysmember fromAggregateExecstruct.Are these changes tested?
Existing tests should work.
Are there any user-facing changes?