fix: Pull stats in IdentVisitor/GraphvizVisitor only when requested#8514
Merged
alamb merged 1 commit intoapache:mainfrom Dec 12, 2023
Merged
fix: Pull stats in IdentVisitor/GraphvizVisitor only when requested#8514alamb merged 1 commit intoapache:mainfrom
IdentVisitor/GraphvizVisitor only when requested#8514alamb merged 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
8 tasks
alamb
approved these changes
Dec 12, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @vrongmeal -- this makes sense to me and I love how well tested it is 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8513.
Rationale for this change
What changes are included in this PR?
Stats are pulled only if they are requested.
Are these changes tested?
Added relevant regression tests.
Are there any user-facing changes?