fix: make sure CASE WHEN pick first true branch when WHEN clause is true#8477
Merged
alamb merged 2 commits intoapache:mainfrom Dec 15, 2023
Merged
fix: make sure CASE WHEN pick first true branch when WHEN clause is true#8477alamb merged 2 commits intoapache:mainfrom
alamb merged 2 commits intoapache:mainfrom
Conversation
github-actions
Bot
added
physical-expr
8 tasks
alamb
approved these changes
Dec 12, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @haohuaijin
Contributor
|
cc @yjshen in case you have afew moments to review |
Contributor
|
Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8475
Rationale for this change
In our current implementation, when
WHENclause is true, we will always pick the last true branch.Because when
WHENis true(WHEN trueor the expression can simplified toWHEN true), we don't setwhen_valueto false (even though it already has the result)in the below code, so we always update thecurrent_value.https://github.com/apache/arrow-datafusion/blob/2765fee4dd7518a4dc39244d1b495329b9771be1/datafusion/physical-expr/src/expressions/case.rs#L194-L208
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?