Merged
Conversation
28 tasks
comphead
approved these changes
Nov 28, 2023
viirya
approved these changes
Nov 28, 2023
viirya
reviewed
Nov 28, 2023
| assert_eq!("c1", physical_plan.schema().field(0).name().as_str()); | ||
| assert_eq!( | ||
| "total_salary", | ||
| physical_plan.schema().field(1).name().as_str() |
Member
There was a problem hiding this comment.
Actually this test doesn't really use DataFrame API but creates logical plan and physical plan with SessionState. Maybe physical-plan? But there doesn't have tests module, so here is also good.
Contributor
Author
There was a problem hiding this comment.
You are right -- I mistakenly assumed that the scan_empty was returning a DataFrame (it is actually returning a LogicalPlanBuilder): https://github.com/alamb/arrow-datafusion/blob/9a15bf89682728a277cc0a8f443fbd4ba8398ae6/datafusion/core/src/test_util/mod.rs#L133
I will see if I can find a better home for this
alamb
commented
Nov 28, 2023
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn aggregate_with_alias() -> Result<()> { |
Contributor
Author
There was a problem hiding this comment.
I found a better place for this test (with the other tests that are checking things about the physical plans)
viirya
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8194
Rationale for this change
Follow on to #8316 I noticed that one of the test was actually using the dataframe API, so it should also be put in the dataframe tests
What changes are included in this PR?
Restore one tests into the dataframe tests
Are these changes tested?
They are all tests
Are there any user-facing changes?