[MINOR]: Remove unecessary orderings from the final plan#8289
Merged
alamb merged 2 commits intoapache:mainfrom Nov 21, 2023
synnada-ai:minor/remove_lost_orderings
Merged
[MINOR]: Remove unecessary orderings from the final plan#8289alamb merged 2 commits intoapache:mainfrom synnada-ai:minor/remove_lost_orderings
alamb merged 2 commits intoapache:mainfrom
synnada-ai:minor/remove_lost_orderings
Conversation
github-actions
Bot
added
core
Contributor
|
(this doesn't exactly do the right thing -- we will update this today and re-open) |
Dandandan
approved these changes
Nov 21, 2023
Dandandan
reviewed
Nov 21, 2023
| // | ||
| // More rationale: | ||
| // https://github.com/apache/arrow-datafusion/pull/6354#discussion_r1195284178 | ||
| match &self.sort_order { |
Contributor
There was a problem hiding this comment.
We experienced some problems with this as well (added sorts), so happy to see this go :)
7 tasks
alamb
approved these changes
Nov 21, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @mustafasrepo and @Dandandan
| ------Projection: aggregate_test_100.c2, aggregate_test_100.c1 | ||
| --------TableScan: aggregate_test_100 projection=[c1, c2] | ||
| physical_plan | ||
| AggregateExec: mode=FinalPartitioned, gby=[c2@0 as c2], aggr=[COUNT(*)] |
Contributor
There was a problem hiding this comment.
👍 it is nice to see no Sort!
alamb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
In some of the plans, there are unnecessary
SortExec, where ordered fields are not used (exist at the final plan.) This PR removeSortExecs for these cases from the plan.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?