Replace array_has/array_has_all/array_has_any macro to remove duplicate code#8263
Merged
alamb merged 3 commits intoapache:mainfrom Nov 20, 2023
Merged
Replace array_has/array_has_all/array_has_any macro to remove duplicate code#8263alamb merged 3 commits intoapache:mainfrom
array_has/array_has_all/array_has_any macro to remove duplicate code#8263alamb merged 3 commits intoapache:mainfrom
Conversation
Signed-off-by: veeupup <code@tanweime.com>
Signed-off-by: veeupup <code@tanweime.com>
Signed-off-by: veeupup <code@tanweime.com>
Veeupup
changed the title
array_has/array_has_all/array_has_any macro to reomve duplicate codearray_has/array_has_all/array_has_any macro to remove duplicate code
Contributor
Author
|
@alamb @jayzhan211 ready for review, thanks! : ) |
jayzhan211
approved these changes
Nov 19, 2023
7 tasks
Contributor
|
Thanks @Veeupup and @jayzhan211 -- I'll try and review this PR today |
alamb
approved these changes
Nov 20, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you very much @Veeupup and @jayzhan211 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
fix
array_has/array_has_all/array_has_anyin #7988datafusion-clibinary size seems to decrease by about 60~KBRationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?