[MINOR] Simplify Aggregate, and Projection output_partitioning implementation#7907
Merged
mustafasrepo merged 1 commit intoapache:mainfrom Oct 24, 2023
synnada-ai:refactor/aggregate_simplification
Merged
[MINOR] Simplify Aggregate, and Projection output_partitioning implementation#7907mustafasrepo merged 1 commit intoapache:mainfrom synnada-ai:refactor/aggregate_simplification
mustafasrepo merged 1 commit intoapache:mainfrom
synnada-ai:refactor/aggregate_simplification
Conversation
alamb
approved these changes
Oct 23, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
This looks like a nice cleanup to me -- thank you @mustafasrepo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This is simplification Pr, to improve readability.
What changes are included in this PR?
Existing tests should work
Are these changes tested?
Are there any user-facing changes?