feat: support Decimal256 for the abs function#7904
Merged
alamb merged 3 commits intoapache:mainfrom Oct 23, 2023
Merged
Conversation
github-actions
Bot
added
physical-expr
viirya
reviewed
Oct 22, 2023
viirya
reviewed
Oct 22, 2023
viirya
reviewed
Oct 22, 2023
comphead
reviewed
Oct 22, 2023
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Perhaps its better to use plan_err or exec_err! instead of ArrowError
Member
Author
Thank you @comphead, but the |
viirya
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
What changes are included in this PR?
Decimal256for theabsfunction.Are these changes tested?
Yes
Are there any user-facing changes?
No