Fix precision loss when coercing date_part utf8 argument#7846
Merged
Dandandan merged 1 commit intoapache:mainfrom Oct 17, 2023
Merged
Fix precision loss when coercing date_part utf8 argument#7846Dandandan merged 1 commit intoapache:mainfrom
Dandandan merged 1 commit intoapache:mainfrom
Conversation
github-actions
Bot
added
logical-expr
fsdvh
approved these changes
Oct 17, 2023
viirya
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7847
Rationale for this change
What changes are included in this PR?
Reordering the function signature to prioritize coercing to higher precision types.
Are these changes tested?
Yes, extra tests added.
Are there any user-facing changes?