Exactness Indicator of Parameters: Precision#7809
Merged
alamb merged 4 commits intoapache:mainfrom Oct 12, 2023
synnada-ai:feature/join-statistics
Merged
Exactness Indicator of Parameters: Precision#7809alamb merged 4 commits intoapache:mainfrom synnada-ai:feature/join-statistics
alamb merged 4 commits intoapache:mainfrom
synnada-ai:feature/join-statistics
Conversation
Contributor
|
This is part of #7793, correct? If so, thank you for extracting it to its own PR |
Contributor
Author
alamb
approved these changes
Oct 12, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
LGTM -- thank you for extracting this out @berkaysynnada
berkaysynnada
changed the title
Contributor
Author
Thank you for the reviews. After these 2 PRs are merged, I will resolve the conflicts of #7793 and request a review again. |
alamb
approved these changes
Oct 12, 2023
Contributor
|
Thanks again @berkaysynnada |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Some parameters need to be carried along with their exactness information. That exactness information can be provided by the source, or it can be set during the execution. This implementation which will initially be useful in statistics can also be used in different areas in the future.
If this approach makes sense and is approved by the community, I will subsequently open a new PR where its importance on statistics will be seen and some optimizations will be possible.
What changes are included in this PR?
An enumeration, named Precision, is implemented to define 3 types of exactness variants: Exact, Inexact, and Absent. The enum can be used in a generic way, and some utilities on usize and ScalarValue have also been added.
Are these changes tested?
Yes, unit tests are added.
Are there any user-facing changes?