Merged
Conversation
github-actions
Bot
added
logical-expr
jackwener
reviewed
Oct 12, 2023
| (Vec::<Column>::new(), Vec::<Column>::new()), | ||
| expr, | ||
| )? | ||
| .join_on(right.plan, join_type, expr)? |
Member
There was a problem hiding this comment.
There are more code can be like this.
like join_on_false() .....
Contributor
There was a problem hiding this comment.
I was also thinking there are some additional documentation improvements that can be done (namely suggesting people use join_on instead of the various other join functions. I can make a PR with such improvements as a follow on, perhaps
alamb
approved these changes
Oct 12, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @haohuaijin -- this is very nice work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7766
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?