Minor: Assert streaming_merge has non empty sort exprs#7795
Merged
alamb merged 6 commits intoapache:mainfrom Oct 16, 2023
Merged
Minor: Assert streaming_merge has non empty sort exprs#7795alamb merged 6 commits intoapache:mainfrom
streaming_merge has non empty sort exprs#7795alamb merged 6 commits intoapache:mainfrom
Conversation
Contributor
Author
|
I verified this assert fires for my test case |
Contributor
Author
jackwener
approved these changes
Oct 16, 2023
viirya
reviewed
Oct 16, 2023
viirya
reviewed
Oct 16, 2023
viirya
approved these changes
Oct 16, 2023
Co-authored-by: jakevin <jakevingoo@gmail.com> Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #7794
Rationale for this change
While debugging #7794 (which I think is a bad plan) the lack of Sort exprs caused very strange behavior that made it harder to debug.
Specifically, the merge code ended up passing bad indices to
interleavewhich resulted in a panic far away from the source of the problem.What changes are included in this PR?
streaming_mergeRowCursorthat there is at least one rowAre these changes tested?
Yes by existing tests
Are there any user-facing changes?
No, only easier to debug failures