Merged
Conversation
alamb
approved these changes
Oct 9, 2023
| /// resolved) for all available partitions, the set of metrics | ||
| /// should be complete. If this function is called prior to | ||
| /// `execute()` new metrics may appear in subsequent calls. | ||
| fn metrics(&self) -> Option<MetricsSet>; |
Contributor
There was a problem hiding this comment.
🤔 I wonder if there is value in making some sort of End to End example for this feature (so we don't accidentally break it in the future0
joroKr21
reviewed
Apr 22, 2024
|
|
||
| /// Returns the metrics of the underlying [DataSink] | ||
| pub fn metrics(&self) -> Option<MetricsSet> { | ||
| self.sink.metrics() |
Contributor
There was a problem hiding this comment.
Ahh this was the wrong place, it should be in impl ExecutionPlan for FileSinkExec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7779
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?