Skip to content

Improve update error #7777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 4 commits into from
Oct 13, 2023
Merged

Improve update error #7777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df7f771
Improve update error
lewiszlw Oct 9, 2023
971f711
Update datafusion/expr/src/logical_plan/dml.rs
lewiszlw Oct 12, 2023
f415dd5
Update datafusion/core/src/physical_planner.rs
lewiszlw Oct 12, 2023
acd7f04
Update datafusion/core/src/physical_planner.rs
lewiszlw Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datafusion/core/src/physical_planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1251,10 +1251,10 @@ impl DefaultPhysicalPlanner {
"Unsupported logical plan: Prepare"
)
}
LogicalPlan::Dml(_) => {
LogicalPlan::Dml(dml) => {
// DataFusion is a read-only query engine, but also a library, so consumers may implement this
not_impl_err!(
"Unsupported logical plan: Dml"
"Unsupported logical plan: Dml({0})", dml.op
)
}
LogicalPlan::Statement(statement) => {
Expand Down
2 changes: 1 addition & 1 deletion datafusion/expr/src/logical_plan/plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ pub enum LogicalPlan {
Prepare(Prepare),
/// Data Manipulaton Language (DML): Insert / Update / Delete
Dml(DmlStatement),
/// Data Definition Language (DDL): CREATE / DROP TABLES / VIEWS / SCHEMAs
/// Data Definition Language (DDL): CREATE / DROP TABLES / VIEWS / SCHEMAS
Ddl(DdlStatement),
/// `COPY TO` for writing plan results to files
Copy(CopyTo),
Expand Down