Skip to content

MINOR: change file to column index in page_filter trace log #7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 4 commits into from
Oct 3, 2023
Merged

MINOR: change file to column index in page_filter trace log #7730

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b58420c
MINOR: change file to column index in page_filter trace log
mapleFU Oct 3, 2023
b5cb335
apply suggestion from review: add comma
mapleFU Oct 3, 2023
21e2109
Merge branch 'main' into minor/change-file-in-trace-to-column-index
mapleFU Oct 3, 2023
27fd827
Merge branch 'main' into minor/change-file-in-trace-to-column-index
mapleFU Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,17 +147,19 @@ impl PagePruningPredicate {

let file_offset_indexes = file_metadata.offset_index();
let file_page_indexes = file_metadata.column_index();
let (file_offset_indexes, file_page_indexes) =
match (file_offset_indexes, file_page_indexes) {
(Some(o), Some(i)) => (o, i),
_ => {
trace!(
"skip page pruning due to lack of indexes. Have offset: {} file: {}",
let (file_offset_indexes, file_page_indexes) = match (
file_offset_indexes,
file_page_indexes,
) {
(Some(o), Some(i)) => (o, i),
_ => {
trace!(
"skip page pruning due to lack of indexes. Have offset: {}, column index: {}",
file_offset_indexes.is_some(), file_page_indexes.is_some()
);
return Ok(None);
}
};
return Ok(None);
}
};

let mut row_selections = Vec::with_capacity(page_index_predicates.len());
for predicate in page_index_predicates {
Expand Down