take schema from record batch when creating mem table if any#7637
Closed
matthewgapp wants to merge 1 commit intoapache:mainfrom
Closed
take schema from record batch when creating mem table if any#7637matthewgapp wants to merge 1 commit intoapache:mainfrom
matthewgapp wants to merge 1 commit intoapache:mainfrom
Conversation
matthewgapp
commented
Sep 24, 2023
| let physical = DataFrame::new(self.state(), input); | ||
|
|
||
| let batches: Vec<_> = physical.collect_partitioned().await?; | ||
| let schema = { |
Contributor
Author
There was a problem hiding this comment.
This solves the bug but feels like the input.schema() should already be correct. We shouldn't need to reach into the record batch to find out the true schema
Contributor
Author
There was a problem hiding this comment.
I haven't investigated enough to know what is the "correct" fix.
Contributor
There was a problem hiding this comment.
I agree input.schema() should be fixed (in the sense that in the RecordBatches produced don't match the schema declared) that is the root cause of the issue
Perhaps this is related to #7636 that you filed
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably better resolved by embedding this information in the logical plan
Which issue does this PR close?
Closes #7636
Rationale for this change
The schema that is saved when using
create tableshould be correct (i.e., it should capturenullable: falserequirements on fields).What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?