Fix up some DataFusionError::Internal errors with correct type#6721
Merged
alamb merged 2 commits intoapache:mainfrom Jun 21, 2023
Merged
Fix up some DataFusionError::Internal errors with correct type#6721alamb merged 2 commits intoapache:mainfrom
DataFusionError::Internal errors with correct type#6721alamb merged 2 commits intoapache:mainfrom
Conversation
github-actions
Bot
added
physical-expr
alamb
force-pushed
the
alamb/audit_internal
branch
from
7721b91 to
3f5baa7
Compare
Contributor
Author
|
cc @wolffcm I am making progress |
comphead
reviewed
Jun 20, 2023
| )) | ||
| } | ||
| } | ||
| other => Err(DataFusionError::Internal(format!( |
Contributor
There was a problem hiding this comment.
should be here Execution as well?
Contributor
Author
There was a problem hiding this comment.
I think this error is if calculate_result_decimal_for_avg gets called with a non DataType::Decimal argument, which I think the type dispatch is supposed to prevent.
Thus I think Internal is still the appropriate error in this area
|
|
||
| result.cloned().ok_or_else(|| { | ||
| DataFusionError::Internal(format!( | ||
| DataFusionError::Plan(format!( |
Contributor
There was a problem hiding this comment.
prob we could have short methods
plan_err(text)
execution_err(text)
...
to replace wordy
DataFusionError::Plan(format!(
text
))
Contributor
Author
There was a problem hiding this comment.
It is an excellent idea. I will try to do this
Contributor
Author
There was a problem hiding this comment.
I tried to implement this idea in #6740 but I found them harder / less easy to use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6108
Rationale for this change
See rationale on #6108
What changes are included in this PR?
Change some errors that don't indicate a code bug in DataFusion to
DataFusionError::ExecutionorDataFusionError::PlanI can't think of any way to avoid allowing new Internal errors to be introduced, but if others have thoughts in that area I would appreciate them
Are these changes tested?
yes, existing tests
Are there any user-facing changes?