fix: build union schema with child has same column name but qualifier…#5452
fix: build union schema with child has same column name but qualifier…#5452alamb merged 1 commit intoapache:mainfrom
Conversation
github-actions
Bot
added
core
|
|
||
| Ok(DFField::new( | ||
| None, | ||
| left_field.qualifier().map(|x| &**x), |
There was a problem hiding this comment.
| left_field.qualifier().map(|x| &**x), | |
| left_field.qualifier().map(|x| x.as_ref()), |
jackwener
left a comment
jackwener
left a comment
There was a problem hiding this comment.
This PR use left-side qualifier instead of discard qualifier when build union.
Make sense to me
| fn test_union_after_join() -> Result<()> { | ||
| let values = vec![vec![lit(1)]]; | ||
|
|
||
| let left = LogicalPlanBuilder::values(values.clone())? |
|
Benchmark runs are scheduled for baseline = 8d195a8 and contender = 53a638e. 53a638e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
5 participants
… is different
Which issue does this PR close?
Closes #5410 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?