reuse code utils::optimize_children but affect inline.#4121
reuse code utils::optimize_children but affect inline.#4121alamb merged 1 commit intoapache:masterfrom
utils::optimize_children but affect inline.#4121Conversation
alamb
left a comment
There was a problem hiding this comment.
This refactor looks good to me -- thank you @jackwener
cc @waynexia who originally contributed this pass in #792
I'll wait at least 24 hours to see if they want to respond or have additional time to review
|
Thanks again @jackwener |
|
Benchmark runs are scheduled for baseline = e2d7b4c and contender = 63386d1. 63386d1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
part of #4120.
It's different from #4119 , this PR make
rewrite_exprbecomemember functionwhich wasinlinefunction originally.refactor it may affect inline. I don't ensure it, so I seperately new a PR. If this PR don't look like good, we can close it.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?