CSE unit test for duplicate fields#2747
Merged
alamb merged 1 commit intoapache:masterfrom Jun 18, 2022
Merged
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2747 +/- ##
=======================================
Coverage 84.93% 84.93%
=======================================
Files 270 270
Lines 47915 47926 +11
=======================================
+ Hits 40695 40706 +11
Misses 7220 7220
Continue to review full report at Codecov.
|
alamb
approved these changes
Jun 18, 2022
|
|
||
| Ok(()) | ||
| } | ||
|
|
waynexia
added a commit
to waynexia/arrow-datafusion
that referenced
this pull request
Jun 20, 2022
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruihang Xia waynestxia@gmail.com
Which issue does this PR close?
Ref #2715
Rationale for this change
#2715 fixed that CSE intermediate projection plan may contain duplicate fields but forget to add a UT to cover it.
This UT test the behavior by trying to build intermediate projection plan twice with the same input. To simulate (sort of) the original scenario that calls optimizer twice. cc @alamb
What changes are included in this PR?
add an UT
redundant_project_fieldsAre there any user-facing changes?