Move LogicalPlanBuilder to datafusion-expr crate#2576
Merged
andygrove merged 4 commits intoapache:masterfrom May 22, 2022
Merged
Move LogicalPlanBuilder to datafusion-expr crate#2576andygrove merged 4 commits intoapache:masterfrom
LogicalPlanBuilder to datafusion-expr crate#2576andygrove merged 4 commits intoapache:masterfrom
Conversation
andygrove
changed the title
LogicalPlanBuilder to datafusion-expr crateLogicalPlanBuilder to datafusion-expr crate
Member
Author
|
@alamb This PR is finally ready for review ... this is what all the previous refactoring PRs were leading to. |
This reverts commit dbdee6b.
yjshen
approved these changes
May 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2536
Rationale for this change
I would like
LogicalPlanBuilderto be in the same crate asLogicalPlan.What changes are included in this PR?
Move
LogicalPlanBuilderto be in the same crate asLogicalPlan.There are no functional changes, just moving code around.
There are public re-exports from the original location, so no changes were needed in Ballista.
Are there any user-facing changes?
Lots of things have moved around.