More documentation on FileSource::table_schema and FileSource::projection#20242
Merged
alamb merged 2 commits intoapache:mainfrom Feb 9, 2026
Merged
More documentation on FileSource::table_schema and FileSource::projection#20242alamb merged 2 commits intoapache:mainfrom
FileSource::table_schema and FileSource::projection#20242alamb merged 2 commits intoapache:mainfrom
Conversation
github-actions
Bot
added
datasource
alamb
commented
Feb 9, 2026
| fn as_any(&self) -> &dyn Any; | ||
|
|
||
| /// Returns the table schema for this file source. | ||
| /// Returns the table schema for the overall table (including partition columns, if any) |
alamb
commented
Feb 9, 2026
| /// | ||
| /// The output schema of this `FileSource` is this TableSchema | ||
| /// with [`Self::projection`] applied. | ||
| /// |
adriangb
approved these changes
Feb 9, 2026
zhuqi-lucas
approved these changes
Feb 9, 2026
Contributor
Author
|
Thanks everyone |
Contributor
Author
|
I'll be happy to do a follow on PR with more docs too if there are othr suggestions |
de-bgunter
pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
…jection` (apache#20242) ## Which issue does this PR close? - Follow on to apache#20188 ## Rationale for this change @zhuqi-lucas and @adriangb had some good ideas on how to further improve the documentation on apache#20188, which I tried to implement in this PR ## What changes are included in this PR? Add more clarity about what TableSource and FileSource::projection are ## Are these changes tested? By CI ## Are there any user-facing changes? Additional documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FileFormat::projection/FileFormat::filterandFileScanConfig::Statistics#20188Rationale for this change
@zhuqi-lucas and @adriangb had some good ideas on how to further improve the documentation on #20188, which I tried to implement in this PR
What changes are included in this PR?
Add more clarity about what TableSource and FileSource::projection are
Are these changes tested?
By CI
Are there any user-facing changes?
Additional documentation