CI : Enforce clippy: :needless_pass_by_value rule to datafusion-functions-aggregate#18805
Merged
alamb merged 1 commit intoapache:mainfrom Nov 19, 2025
Merged
CI : Enforce clippy: :needless_pass_by_value rule to datafusion-functions-aggregate#18805alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
codetyri0n
changed the title
Contributor
Author
|
CC : @2010YOUY01 |
Jefffrey
approved these changes
Nov 18, 2025
Contributor
|
Thanks @codetyri0n and @Jefffrey |
logan-keede
pushed a commit
to logan-keede/datafusion
that referenced
this pull request
Nov 23, 2025
…tions-aggregate (apache#18805) ## Which issue does this PR close? - Closes apache#18759 and part of apache#18503 ## What changes are included in this PR? enforce clippy lint needless_pass_by_value to datafusion-functions-aggregate crate. ## Are these changes tested? yes ## Are there any user-facing changes? no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
clippy::needless_pass_by_valuetodatafusion-functions-aggregate#18759 and part of [Tracking] Rollout of new lintclippy::needless_pass_by_valuein all datafusion crates #18503What changes are included in this PR?
enforce clippy lint needless_pass_by_value to datafusion-functions-aggregate crate.
Are these changes tested?
yes
Are there any user-facing changes?
no