Introduce Signature::String and return error if input of strpos is integer#12751
Merged
jayzhan211 merged 14 commits intoapache:mainfrom Oct 8, 2024
Merged
Introduce Signature::String and return error if input of strpos is integer#12751jayzhan211 merged 14 commits intoapache:mainfrom
strpos is integer#12751jayzhan211 merged 14 commits intoapache:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I think #12712 introduce a regression on integer type, this PR introduce another signature for string, and return error for integer input on
strposfunction, which has the same result as PostgresWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Others
Not sure is this generalize to all the string related function. Are they all expect converting null to String? Handle dictionary?