Skip to content

Move FileSinkExec::metrics to the correct place #10901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dandandan merged 1 commit into from
Jun 13, 2024
Merged

Move FileSinkExec::metrics to the correct place #10901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions datafusion/physical-plan/src/insert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,11 +175,6 @@ impl DataSinkExec {
&self.sort_order
}

/// Returns the metrics of the underlying [DataSink]
pub fn metrics(&self) -> Option<MetricsSet> {
self.sink.metrics()
}

fn create_schema(
input: &Arc<dyn ExecutionPlan>,
schema: SchemaRef,
Expand Down Expand Up @@ -289,6 +284,11 @@ impl ExecutionPlan for DataSinkExec {
stream,
)))
}

/// Returns the metrics of the underlying [DataSink]
fn metrics(&self) -> Option<MetricsSet> {
self.sink.metrics()
}
}

/// Create a output record batch with a count
Expand Down