Minor: add Window::try_new_with_schema constructor#10850
Conversation
| ) | ||
| } | ||
|
|
||
| pub fn try_new_with_schema( |
There was a problem hiding this comment.
Perhaps we can add some documentation strings that explain how this is different than Window::try_new (specifically that the schema check is much faster)?
alamb
left a comment
There was a problem hiding this comment.
Also I wonder if we could update at least one callsite to use try_new_with_schema so we get some test coverage 🤔
|
I think it is reasonable enough 🤔 . It might be good as a follow on PR to add another external callsite so that we don't accidentally mess up this API by accident) |
|
Thanks again @sadboy -- We can add additional documentation as a follow on PR |
Which issue does this PR close?
Closes N/A
Rationale for this change
This change makes the
Windownode API more uniform with otherLogicalPlannodes, which all expose bothtry_newandtry_new_with_schemaconstructors.What changes are included in this PR?
New method
Window::try_new_with_schemaAre these changes tested?
Covered by existing tests.
Are there any user-facing changes?
No.