Skip to content

Make function modules public, add Default impl's.#10239

Merged
andygrove merged 1 commit intoapache:mainfrom
Omega359:main
Apr 26, 2024
Merged

Make function modules public, add Default impl's.#10239
andygrove merged 1 commit intoapache:mainfrom
Omega359:main

Conversation

@Omega359
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #10164

Rationale for this change

Code consistency.

What changes are included in this PR?

Code updates.

Are these changes tested?

Yes.

Are there any user-facing changes?

Functions are now accessible.

@Omega359 Omega359 marked this pull request as ready for review April 26, 2024 01:23
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 -- thank you @Omega359

cc @universalmind303

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 26, 2024

Thank you @Omega359 🙏

Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Omega359

@andygrove andygrove merged commit 4ec3d51 into apache:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make all modules in function crate public, add Default impl's for all Func's

3 participants