test: unignore InjectRuntimeFilterSuite tests gated on issue #242#4178
Merged
andygrove merged 1 commit intoapache:mainfrom May 3, 2026
Merged
test: unignore InjectRuntimeFilterSuite tests gated on issue #242#4178andygrove merged 1 commit intoapache:mainfrom
andygrove merged 1 commit intoapache:mainfrom
Conversation
Spark already has Comet support for SubqueryBroadcastExec via CometSubqueryBroadcastExec, so the two InjectRuntimeFilterSuite tests that were skipped with IgnoreComet referencing issue apache#242 can now run. The 3.5.8 diff already runs them un-ignored; this aligns 3.4.3, 4.0.2, and 4.1.1. Verified by running the two tests on Spark 3.5.8 with ENABLE_COMET=true: both pass. Their assertions only inspect logical plans, so no Comet-aware modifications are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #242.
Rationale for this change
Two tests in
InjectRuntimeFilterSuiteare skipped viaIgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")in the Spark 3.4.3, 4.0.2, and 4.1.1 diffs. Comet already providesCometSubqueryBroadcastExec, and the corresponding 3.5.8 diff already runs these two tests un-ignored. This PR aligns the other Spark version diffs with that behavior so we get the additional coverage.What changes are included in this PR?
Regenerates
dev/diffs/3.4.3.diff,dev/diffs/4.0.2.diff, anddev/diffs/4.1.1.diffto drop theIgnoreCometannotations on:Runtime bloom filter join: do not add bloom filter if dpp filter exists on the same columnRuntime bloom filter join: add bloom filter if dpp filter exists on a different columndev/diffs/3.5.8.diffalready had no#242references and is unchanged.How are these changes tested?
The two tests were run on Spark 3.5.8 with
ENABLE_COMET=true ENABLE_COMET_ONHEAP=trueand both passed. The assertions only inspect logical plans (BloomFilterAggregateinsideScalarSubquery,BloomFilterMightContaininFilterconditions), so they are unaffected by the choice of physical operator. CI will run the tests for 3.4.3, 4.0.2, and 4.1.1.