Skip to content

feat:support ansi mode remainder function#2556

Merged
andygrove merged 4 commits intoapache:mainfrom
coderfender:support_ansi_mode_remainder_function
Oct 14, 2025
Merged

feat:support ansi mode remainder function#2556
andygrove merged 4 commits intoapache:mainfrom
coderfender:support_ansi_mode_remainder_function

Conversation

@coderfender
Copy link
Copy Markdown
Contributor

@coderfender coderfender commented Oct 12, 2025

Which issue does this PR close?

Closes #2555 .

Original ANSI support PR : #1971
Issue : #1971

Rationale for this change

  1. Support ANSI mode for remainder function

What changes are included in this PR?

Update CometRound class and remove getSupportLevel which is no longer relevant

How are these changes tested?

We already have ANSI tests which pass on this branch

@coderfender
Copy link
Copy Markdown
Contributor Author

@andygrove , @rishvin I created this PR to fix a bug which prevents executing CometRemainder function in ANSI mode

@coderfender coderfender changed the title support_ansi_mode_remainder_function feat:support_ansi_mode_remainder_function Oct 12, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.09%. Comparing base (f09f8af) to head (5937478).
⚠️ Report is 598 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2556      +/-   ##
============================================
+ Coverage     56.12%   59.09%   +2.96%     
- Complexity      976     1457     +481     
============================================
  Files           119      146      +27     
  Lines         11743    13653    +1910     
  Branches       2251     2361     +110     
============================================
+ Hits           6591     8068    +1477     
- Misses         4012     4365     +353     
- Partials       1140     1220      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderfender coderfender changed the title feat:support_ansi_mode_remainder_function feat:support ansi_mode remainder function Oct 13, 2025
@coderfender coderfender changed the title feat:support ansi_mode remainder function feat:support ansi mode remainder function Oct 13, 2025
Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coderfender. Does the documentation also need updating?

@coderfender
Copy link
Copy Markdown
Contributor Author

coderfender commented Oct 13, 2025

@andygrove , I generally create a separate doc PR but given that this is a minor change, let me go ahead and make changes to update documentation as well

@rishvin
Copy link
Copy Markdown
Contributor

rishvin commented Oct 13, 2025

LGTM.

@rishvin
Copy link
Copy Markdown
Contributor

rishvin commented Oct 13, 2025

Do we need to prefix git message and PR title with "chore:" ?

@coderfender
Copy link
Copy Markdown
Contributor Author

thank you for the review @andygrove , @rishvin . I updated documentation per review.

@andygrove
Copy link
Copy Markdown
Member

@coderfender There is a merge conflict from merging your other ANSI PR just now

@coderfender
Copy link
Copy Markdown
Contributor Author

Sure let me get the merge conflicts resolved right away

@coderfender coderfender force-pushed the support_ansi_mode_remainder_function branch from 481fa1e to 5937478 Compare October 13, 2025 23:33
@coderfender
Copy link
Copy Markdown
Contributor Author

coderfender commented Oct 13, 2025

@andygrove ,thank you very much . I fixed the merge conflict. Please kickoff CI and merge the feature branch once you get a chance

@andygrove andygrove merged commit 09dc7cc into apache:main Oct 14, 2025
102 checks passed
coderfender added a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ANSI mode is not supported in Remainder function (despite having support on native side)

4 participants