feat:support ansi mode remainder function#2556
Conversation
|
@andygrove , @rishvin I created this PR to fix a bug which prevents executing CometRemainder function in ANSI mode |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2556 +/- ##
============================================
+ Coverage 56.12% 59.09% +2.96%
- Complexity 976 1457 +481
============================================
Files 119 146 +27
Lines 11743 13653 +1910
Branches 2251 2361 +110
============================================
+ Hits 6591 8068 +1477
- Misses 4012 4365 +353
- Partials 1140 1220 +80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
left a comment
There was a problem hiding this comment.
Thanks @coderfender. Does the documentation also need updating?
|
@andygrove , I generally create a separate doc PR but given that this is a minor change, let me go ahead and make changes to update documentation as well |
|
LGTM. |
|
Do we need to prefix git message and PR title with "chore:" ? |
|
thank you for the review @andygrove , @rishvin . I updated documentation per review. |
|
@coderfender There is a merge conflict from merging your other ANSI PR just now |
|
Sure let me get the merge conflicts resolved right away |
481fa1e to
5937478
Compare
|
@andygrove ,thank you very much . I fixed the merge conflict. Please kickoff CI and merge the feature branch once you get a chance |
Which issue does this PR close?
Closes #2555 .
Original ANSI support PR : #1971
Issue : #1971
Rationale for this change
What changes are included in this PR?
Update
CometRoundclass and removegetSupportLevelwhich is no longer relevantHow are these changes tested?
We already have ANSI tests which pass on this branch