commons-text - SANDBOX-492: StringMetricFrom<R>#3
Closed
j--baker wants to merge 7 commits intoapache:masterfrom
j--baker:SANDBOX-492
Closed
commons-text - SANDBOX-492: StringMetricFrom<R>#3j--baker wants to merge 7 commits intoapache:masterfrom j--baker:SANDBOX-492
j--baker wants to merge 7 commits intoapache:masterfrom
j--baker:SANDBOX-492
Conversation
Add StringMetricFrom<R> and a few unit tests.
- Add more test cases. - Add TODOs to add more when SANDBOX-491 is ready, which will allow configuration details for the StringMetric to be saved in fields.
- Add example usage in javadoc of StringMetricFrom. - Add this example as a unit test.
- Merge changes from SANDBOX-493 ("compare" -> "apply").
- Added FuzzyScore tests. - Added limited LevenshteinDistance tests.
Contributor
Author
|
Merged in SANDBOX-491 (parameterized StringMetric constructors) and SANDBOX-493 (change "compare" to "apply" to match Java 8). Please review this PR. Thanks. |
Carmineh
added a commit
to Carmineh/commons-text
that referenced
this pull request
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP. I will add more unit tests when/if SANDBOX-491 is merged into master.
Also, I'd like to pull in the SANDBOX-493 (compare()->apply()) changes, but I assume I should wait until 493 is pulled into master.