Fix direct download https compressed qcow2 template checker

[nvazquez]

Description

This PR fixes an issue on direct download while registering HTTPS compressed files
Fixes: #7929

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

@nvazquez, does this mean regestering compressed qcow files is no longer possible at all?

[nvazquez]

@DaanHoogland no, it means that compressed qcow2 files on HTTPS will use the general remote size logic instead of the QCOW2Utils to get the remote size on the HttpsDirectTemplateDownloader

[weizhouapache]

thanks @nvazquez for the fix

I am able to register the systemvm template 👍

The only issue is the size of the template.

register with https:

register with http

[yadvr]

LGTM, didn't test it though

[blueorangutan]

Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6951

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6952

[codecov]

Codecov Report

Merging #7932 (f6cd86e) into 4.18 (439d70f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.18    #7932      +/-   ##
============================================
- Coverage     13.06%   13.06%   -0.01%     
  Complexity     9093     9093              
============================================
  Files          2720     2720              
  Lines        257431   257434       +3     
  Branches      40141    40142       +1     
============================================
  Hits          33622    33622              
- Misses       219582   219585       +3     
  Partials       4227     4227              

Files Changed	Coverage Δ
...r/kvm/resource/wrapper/LibvirtCheckUrlCommand.java	16.66% <0.00%> (-5.56%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[shwstppr]

Code LGTM

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[nvazquez]

@blueorangutan package

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6954

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

lgtm didnt test it

[weizhouapache]

Tested ok

• qcow2 with http
• qcow2 with https
• qcow2.bz2 with http
• qcow2.bz2 with https

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[harikrishna-patnala]

Code LGTM

[blueorangutan]

[SF] Trillian test result (tid-7619)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42848 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7932-t7619-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	Failure	0.04	test_ssvm.py
test_04_cpvm_internals	Failure	0.04	test_ssvm.py
test_08_upgrade_kubernetes_ha_cluster	Failure	617.83	test_kubernetes_clusters.py

[shwstppr]

Code lgtm

[blueorangutan]

[SF] Trillian test result (tid-7620)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41550 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7932-t7620-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File