Proposal for an improved CglibThrowableRenderer#762
Conversation
|
cloudstack-pull-rats #445 FAILURE |
|
cloudstack-pull-rats #446 SUCCESS |
|
cloudstack-pull-rats #447 SUCCESS |
Apache license Shame on me... Fix test to pass on travis build
|
cloudstack-pull-analysis #378 UNSTABLE |
|
cloudstack-pull-analysis #379 UNSTABLE |
|
cloudstack-pull-analysis #380 ABORTED |
rafaelweingartner
force-pushed
the
cglibThrowableRenderer
branch
from
e2d5e21 to
89bac52
Compare
|
cloudstack-pull-rats #448 SUCCESS |
|
cloudstack-pull-analysis #381 SUCCESS |
|
LGTM, reviewing this I finally understand why we have a custom renderer at all. The travis failing checks are unrelated timeouts. |
|
Does anyone else have some ideas on how to test that code? |
|
cloudstack-pull-rats #453 SUCCESS |
|
cloudstack-pull-analysis #386 UNSTABLE |
|
The tests that have failed do not seem to be related to the code that was changed. |
|
@rafaelweingartner I see windows line endings in the new test file. Can you fix that please? |
|
since this fixes slow build, I am going to merge this PR and push another commit for line endings fix. |
Proposal for an improved CglibThrowableRendererFollowing our discussions on mailing list, here is a PR with a proposal for an improvement on CglibThrowableRenderer. We would still have to define a number to limit the stack traces of causes (I randomly chose 3, just to get the code running). The test case is also not good in my opinion, but I ran out of ideas (waiting for suggestions on that). * pr/762: Changed the test case to test each of the log traces in the array list. Proposal for an improved CglibThrowableRenderer Signed-off-by: Rajani Karuturi <rajani.karuturi@citrix.com>
|
@karuturi, Sorry for the windows line endings (did you see that on log files? I was not able to see anything there). Sometimes I jump between OS and forget that I am coding from a Windows machine, instead of my usual Ubuntu. BTW: I think we are in very different time zones, I just woke up. Thanks for the windows line fix. |
|
cat -v filename will show you line endings. |
|
With your comments, I fixed my Eclipse configuration on my Windows On Tue, Sep 1, 2015 at 9:33 AM, Rajani Karuturi notifications@github.com
Rafael Weingärtner |
* vm: add dropdown select IP for network type is Shared * remove function not use Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
…nto '4.16.0.0-scclouds' [VMware] Alterar validação sobre donos da rede ao importar VMs Closes apache#762 See merge request scclouds/scclouds!307
5 participants
Following our discussions on mailing list, here is a PR with a proposal for an improvement on “CglibThrowableRenderer”. We would still have to define a number to limit the stack traces of causes (I randomly chose 3, just to get the code running). The test case is also not good in my opinion, but I ran out of ideas (waiting for suggestions on that).