ui: fix suitable shared network not showing while import#7016
Merged
yadvr merged 1 commit intoapache:4.17from Dec 23, 2022
Merged
ui: fix suitable shared network not showing while import#7016yadvr merged 1 commit intoapache:4.17from
yadvr merged 1 commit intoapache:4.17from
Conversation
In import VM form, shared network is not showing when it is in Setup state which should not be the case. This PR fixes that. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
12 tasks
yadvr
approved these changes
Dec 22, 2022
Codecov Report
@@ Coverage Diff @@
## 4.17 #7016 +/- ##
=========================================
Coverage 10.36% 10.36%
- Complexity 6628 6630 +2
=========================================
Files 2453 2453
Lines 242386 242386
Branches 37928 37928
=========================================
+ Hits 25116 25120 +4
+ Misses 214163 214158 -5
- Partials 3107 3108 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In import VM form, shared network is not showing when it is in Setup state which should not be the case. This PR fixes that.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?