system_use column is not part of disk offering#6015
Merged
DaanHoogland merged 1 commit intomainfrom Feb 22, 2022
Merged
Conversation
harikrishna-patnala
requested review from
DaanHoogland,
sureshanaparti and
weizhouapache
DaanHoogland
approved these changes
Feb 21, 2022
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
if disk offerings are indeed never exclusive for system use, this criterium should not be there indeed.
…fering table, because it is applicable only to service offering. There is a left over usage of system_use when user tries to list disk offering. Now we deleted that reference.
harikrishna-patnala
force-pushed
the
FixUserListingDiskOffering
branch
from
bd6d8d5 to
74a15a5
Compare
Member
Author
|
@blueorangutan package |
|
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
| throw new InvalidParameterValueException("Only ROOT admins and Domain admins can list disk offerings with isrecursive=true"); | ||
| } | ||
| } else { // domain + all ancestors | ||
| sc.addAnd("systemUse", SearchCriteria.Op.EQ, false); // non-root users should not see system offering at all |
Contributor
There was a problem hiding this comment.
this is moved to service/compute offering, not needed while listing disk offerings.
sureshanaparti
approved these changes
Feb 21, 2022
nvazquez
approved these changes
Feb 21, 2022
Contributor
|
@blueorangutan package |
|
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2673 |
Member
|
@blueorangutan test |
|
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6013
system_use is used to be in disk_offering table before 4.17 which is only applicable to the system service offering. This column is now moved from disk_offering table to service_offering table.
There is a leftover usage of system_use when a user tries to list disk offering. Now we deleted that reference to fix the issue when a user tries to list disk offering.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
How Has This Been Tested?