ui: fix create account/user with saml#5481
Conversation
Fixes apache#5478 Signed-off-by: Abhishek Kumar <[email protected]>
|
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@shwstppr couple of issues, not sure if they are due to the qa.cloudstack.cloud backend of 4.15.1: (the qa.cloudstack.cloud is SAMl enabled and can be used for testing)
Note: this form also seems to pass invalid entityid in the API, so the user isn't really SAML enabled. @shwstppr please also test/fix any issues with the createAccount form (which also has the saml authorisation option). |
Fixes apache#5477 Signed-off-by: Abhishek Kumar <[email protected]>
|
@rhtyd Verified mentioned issues with PR build:
Addressed #5477 and #5478 |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
UI build: ✔️ |
yadvr
left a comment
There was a problem hiding this comment.
LGTM - I'll test and confirm shortly
|
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@shwstppr outstanding/new issues:
|
Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr is this ready for final test/merge, or you addressing minor issues too? |
|
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@rhtyd let's move ahead with one for 2
I'll fix 1 and 3 in another PR #5487 |
|
LGTM tested! |





Description
Fixes #5477
Fixes #5478
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before change:
After change:

How Has This Been Tested?