engine: add support for VMware 7.0 dependency and hypervisor capability by yadvr · Pull Request #4300 · apache/cloudstack

yadvr · 2020-09-01T09:12:57Z

This adds support for VMware 7.0 with a jar dependency and sql upgrade path. The jar dependency has been added to support noredist pkging here:
https://github.com/rhtyd/cloudstack-nonoss/blob/master/install-non-oss.sh#L37

Fixes #4441
Fixes #4423

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

yadvr · 2020-09-01T09:21:34Z

@blueorangutan package

blueorangutan · 2020-09-01T09:22:12Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-01T10:16:21Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1865

yadvr · 2020-09-02T08:39:58Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2020-09-02T08:51:01Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-02T08:51:01Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-02T08:51:06Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-02T08:51:06Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-02T08:51:06Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-02T08:51:07Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-02T08:51:08Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-02T08:51:08Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-02T08:51:10Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-02T08:51:11Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-02T08:51:12Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

yadvr · 2020-09-07T19:52:46Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2020-09-07T19:53:30Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-09-08T17:53:05Z

Trillian test result (tid-2694)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 77101 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t2694-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 78 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	`Error`	970.19	test_kubernetes_supported_versions.py
test_07_reboot_ssvm	`Failure`	41.90	test_ssvm.py
test_08_reboot_cpvm	`Failure`	42.89	test_ssvm.py

yadvr · 2020-10-20T09:40:08Z

Kicked tests against vCenter 7 based env.

yadvr · 2020-10-21T11:11:31Z

Marvin tests with this PR and vCenter 7.0 with CentOS7 mgmt server but two 6.7u3 ESXi hosts:

Test	Result	Time (s)	Test File
test_01_deploy_kubernetes_cluster	`Error`	0.15	test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster	`Error`	0.07	test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster	`Error`	0.06	test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster	`Error`	0.07	test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster	`Error`	0.06	test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster	`Error`	0.06	test_kubernetes_clusters.py
test_01_add_primary_storage_disabled_host	`Error`	0.51	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.18	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.31	test_primary_storage.py
test_02_list_snapshots_with_removed_data_store	`Error`	1.21	test_snapshots.py
test_02_create_template_with_checksum_sha1	`Error`	5.28	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	5.20	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	5.20	test_templates.py
test_01_volume_usage	`Error`	11.57	test_usage.py
test_11_migrate_vm	`Error`	50.32	test_vm_life_cycle.py
test_01_create_volume	`Error`	134.77	test_volumes.py
test_02_attach_volume	`Error`	44.96	test_volumes.py
test_03_download_attached_volume	`Error`	1.10	test_volumes.py
test_04_delete_attached_volume	`Error`	1.11	test_volumes.py
test_05_detach_volume	`Error`	1.10	test_volumes.py
test_06_download_detached_volume	`Error`	1.11	test_volumes.py
test_07_resize_fail	`Error`	2.28	test_volumes.py
test_08_resize_volume	`Error`	1.11	test_volumes.py
test_09_delete_detached_volume	`Error`	12.63	test_volumes.py
test_11_attach_volume_with_unstarted_vm	`Error`	2.39	test_volumes.py
ContextSuite context=TestVolumes>:teardown	`Error`	19.09	test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	443.14	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	3790.27	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	3790.31	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	0.01	test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardown	`Error`	0.02	test_vpc_redundant.py

yadvr · 2020-10-21T11:20:34Z

@blueorangutan package

blueorangutan · 2020-10-21T11:21:59Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-10-21T12:07:05Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2250

yadvr · 2020-10-21T12:14:56Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-04-09T15:24:32Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 377

nvazquez · 2021-04-10T04:44:04Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-04-10T04:45:02Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2021-04-10T15:30:05Z

Trillian test result (tid-399)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37625 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t399-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestVAppsVM>:setup	`Error`	82.81	test_vm_life_cycle.py

yadvr · 2021-04-12T18:24:44Z

@nvazquez can you kick smoketests against vmware 7.0 as well? And if we can get support for vsphere7 in Trillian?

nvazquez · 2021-04-14T12:18:17Z

@blueorangutan help

blueorangutan · 2021-04-14T12:19:03Z

@nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

nvazquez · 2021-04-14T12:48:33Z

@blueorangutan help

blueorangutan · 2021-04-14T12:49:02Z

@nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-70u1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

nvazquez · 2021-04-14T12:51:47Z

@blueorangutan package

blueorangutan · 2021-04-14T12:53:02Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-04-14T13:14:34Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 411

nvazquez · 2021-04-14T14:00:42Z

@blueorangutan test centos7 vmware-70u1

blueorangutan · 2021-04-14T14:02:02Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests

blueorangutan · 2021-04-15T00:31:25Z

Trillian test result (tid-441)
Environment: vmware-70u1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36325 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t441-vmware-70u1.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_10_traceroute_in_vr	`Failure`	61.16	test_diagnostics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	347.83	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	243.03	test_vpc_vpn.py

nvazquez · 2021-04-15T01:25:13Z

@rhtyd @vladimirpetrov Vmware 7.0 support was introduced into Trillian and the last tests were executed on it, few errors which seem unrelated to this PR. Please advise if we are ready to merge it

yadvr · 2021-04-15T07:18:05Z

LGTM, @vladimirpetrov are you lgtm on this?

vladimirpetrov

Testing finished, LGTM @nvazquez, @rhtyd !

yadvr · 2021-04-15T10:40:03Z

Merging based on tests and code reviews.

yadvr added this to the 4.16.0.0 milestone Sep 1, 2020

apache deleted a comment from blueorangutan Sep 7, 2020

yadvr requested review from DaanHoogland, nvazquez and sureshanaparti October 20, 2020 11:18

yadvr assigned nvazquez Oct 21, 2020

apache deleted a comment from blueorangutan Apr 14, 2021

VMware 7 support

f89e60d

nvazquez force-pushed the vsphere7 branch from 7d5c4f5 to f89e60d Compare April 14, 2021 12:51

apache deleted a comment from blueorangutan Apr 14, 2021

vladimirpetrov approved these changes Apr 15, 2021

View reviewed changes

yadvr merged commit 0302750 into apache:4.15 Apr 15, 2021

yadvr mentioned this pull request Apr 15, 2021

cpvm not support VMware 7.0 console #4441

Closed

weizhouapache mentioned this pull request Sep 8, 2021

Console Proxy & VMware 7 websocket issue #5413

Closed

weizhouapache mentioned this pull request Feb 1, 2022

Ajax-based VM console does not work on vmware 7 #5919

Closed

DaanHoogland pushed a commit to shapeblue/cloudstack that referenced this pull request May 20, 2022

vmware: Add support for VMware 7 (apache#4300)

3ded352

shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Jan 17, 2023

vmware: Add support for VMware 7 (apache#4300)

584cbff

Conversation

yadvr commented Sep 1, 2020 • edited by DaanHoogland Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

Uh oh!

yadvr commented Sep 1, 2020

Uh oh!

blueorangutan commented Sep 1, 2020

Uh oh!

blueorangutan commented Sep 1, 2020

Uh oh!

yadvr commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

blueorangutan commented Sep 2, 2020

Uh oh!

yadvr commented Sep 7, 2020

Uh oh!

blueorangutan commented Sep 7, 2020

Uh oh!

blueorangutan commented Sep 8, 2020

Uh oh!

yadvr commented Oct 20, 2020

Uh oh!

yadvr commented Oct 21, 2020

Uh oh!

yadvr commented Oct 21, 2020

Uh oh!

blueorangutan commented Oct 21, 2020

Uh oh!

blueorangutan commented Oct 21, 2020

Uh oh!

yadvr commented Oct 21, 2020

Uh oh!

blueorangutan commented Apr 9, 2021

Uh oh!

nvazquez commented Apr 10, 2021

Uh oh!

blueorangutan commented Apr 10, 2021

Uh oh!

blueorangutan commented Apr 10, 2021

Uh oh!

yadvr commented Apr 12, 2021

Uh oh!

nvazquez commented Apr 14, 2021

Uh oh!

blueorangutan commented Apr 14, 2021

Uh oh!

nvazquez commented Apr 14, 2021

Uh oh!

blueorangutan commented Apr 14, 2021

Uh oh!

nvazquez commented Apr 14, 2021

Uh oh!

blueorangutan commented Apr 14, 2021

Uh oh!

blueorangutan commented Apr 14, 2021

Uh oh!

nvazquez commented Apr 14, 2021

Uh oh!

blueorangutan commented Apr 14, 2021

yadvr commented Sep 1, 2020 •

edited by DaanHoogland

Loading