Allow updatePod API requests to update startIP and endIP

[kioie]

Signed-off-by: kioie kioie@gmail.com

Description

Fixes #2797

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

List the pods

(local) mycloudmonkey> list pods
{
  "count": 1,
  "pod": [
    {
      "allocationstate": "Enabled",
      "endip": [
        "172.16.15.100"
      ],
      "forsystemvms": [
        "0"
      ],
      "gateway": "172.16.15.1",
      "id": "40adabdc-c075-434d-ad96-4ac09a57174a",
      "name": "POD0",
      "netmask": "255.255.255.0",
      "startip": [
        "172.16.15.3"
      ],
      "vlanid": [
        "vlan://untagged"
      ],
      "zoneid": "2c4b017c-a7cf-448d-9846-eddb19868369",
      "zonename": "Sandbox-simulator"
    }
  ]
}

Update pod endIP

(local) mycloudmonkey> update pod id=40adabdc-c075-434d-ad96-4ac09a57174a endip=172.16.15.200
{
  "pod": {
    "allocationstate": "Enabled",
    "endip": [
      "172.16.15.200"
    ],
    "forsystemvms": [
      "0"
    ],
    "gateway": "172.16.15.1",
    "id": "40adabdc-c075-434d-ad96-4ac09a57174a",
    "name": "POD0",
    "netmask": "255.255.255.0",
    "startip": [
      "172.16.15.3"
    ],
    "vlanid": [
      "vlan://untagged"
    ],
    "zoneid": "2c4b017c-a7cf-448d-9846-eddb19868369",
    "zonename": "Sandbox-simulator"
  }
}

Update pod startIP

(local) mycloudmonkey> update pod id=40adabdc-c075-434d-ad96-4ac09a57174a startip=172.16.15.2
{
  "pod": {
    "allocationstate": "Enabled",
    "endip": [
      "172.16.15.200"
    ],
    "forsystemvms": [
      "0"
    ],
    "gateway": "172.16.15.1",
    "id": "40adabdc-c075-434d-ad96-4ac09a57174a",
    "name": "POD0",
    "netmask": "255.255.255.0",
    "startip": [
      "172.16.15.2"
    ],
    "vlanid": [
      "vlan://untagged"
    ],
    "zoneid": "2c4b017c-a7cf-448d-9846-eddb19868369",
    "zonename": "Sandbox-simulator"
  }
}

Updates in the DB

[yadvr]

user_ip_address table may need updating, and also several others checks may be necessary around IP range overlaps etc.

[kioie]

@blueorangutan package

[blueorangutan]

@kioie a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-101

[andrijapanicsb]

@blueorangutan package

[blueorangutan]

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[andrijapanicsb]

@kioie have you tested this one - does it update the mentioned user_ip_address table (add or remove IPs if the range is being expanded or shrinked) ?

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-531

[kioie]

@kioie have you tested this one - does it update the mentioned user_ip_address table (add or remove IPs if the range is being expanded or shrinked) ?

checks for overlaps without updating any allocation states, if state=allocated, overlap will return true and update will fail

[kioie]

@kioie have you tested this one - does it update the mentioned user_ip_address table (add or remove IPs if the range is being expanded or shrinked) ?

Hey @andrijapanicsb @rhtyd since this is pod IP edit, I think its op_dc_ip_address_alloc table as opposed to user_ip_address table, correct?

[yadvr]

Thanks for the PR @kioie - are you able to work on this, or is this work/PR abandoned?

[sureshanaparti]

@rohityadavcloud It seems the same functionality was addressed in the PR #4010 with a new updatePodManagementNetworkIpRange API , and the work there was continued later in the PR #5458. So, I think, this PR is not valid and can be closed. Do you agree @kioie ?

[DaanHoogland]

implemented by #5458