CLOUDSTACK-10012: Embedded Jetty for CloudStack#2197
CLOUDSTACK-10012: Embedded Jetty for CloudStack#2197yadvr wants to merge 1 commit intoapache:masterfrom
Conversation
WIP embedded jetty support Changes adapted from PR apache#372 and apache#1546 Signed-off-by: Rohit Yadav <[email protected]>
|
@rhtyd What's the reason to create another (sub)module of the client, instead of adding a profile to the client module to either produce a tomcat or jetty artifact? Would be nice to created a shaded jar including Jetty server, to have a "short" classpath (bouncycastle JCE is still required on the classpath, therefore it's not possible to create a single fat jar to run due to the signature checks). I could help you on that since it's the way we run it ourself. |
|
@marcaurele thanks, any help would be great. The important goal is to move away from distro provided tomcat, I'm open to all possible ways to do that. Having a fat jar would be great, but for the first step if that's not possible I can do without that approach. |
wido
left a comment
wido
left a comment
There was a problem hiding this comment.
Good work! I have a few comments
| SU="/sbin/runuser -s /bin/sh" | ||
| else | ||
| SU="/bin/su -s /bin/sh" | ||
| fi |
| CLASSPATH="${CLASSPATH}:${CLOUD_HOME}/lib/jetty-runner.jar" | ||
| CLASS="org.eclipse.jetty.runner.Runner --classes /etc/cloudstack/management --path /client $CLOUD_HOME/webapps/client --stop-port 8888 --stop-key monkeystop" | ||
|
|
||
| if [ "$1" = "start" ]; then |
There was a problem hiding this comment.
Shouldn't this just be a wrapper script that systemd can execute? As we want to start/stop everything through systemd
|
@wido thanks, this does not work as of now and needs some further changes. I wanted to start and do this in open to gather some initial feedback and advise. |
|
@rhtyd How could we work together on a branch? My idea was to push what we have (still based on 4.4.2) and let you adapt it to make it work with upstream version since I don't have a way to test upstream correctly |
|
Thanks @marcaurele if you can share your idea as a PR, I can use it as reference and adapt as necessary. I think the general goal is to fix the problem, whatever way necessary. By moving away from tomcat (distro provided), can help in CloudStack's adoption (and as a fatjar somewhere in future). |
|
Closing this in light of #2207 |
3 participants
This is work-in-progress WIP embedded jetty support. Feedback welcome!
Changes adapted from PR #372 and #1546
Signed-off-by: Rohit Yadav [email protected]