Skip to content

Fix NPE during reset password#12585

Open
sureshanaparti wants to merge 1 commit intoapache:4.20from
shapeblue:reset-pswd-npe-fix
Open

Fix NPE during reset password#12585
sureshanaparti wants to merge 1 commit intoapache:4.20from
shapeblue:reset-pswd-npe-fix

Conversation

@sureshanaparti
Copy link
Contributor

Description

This PR fixes the NPE during reset password, and has some code improvements. Failed to throw proper error when there is no session while resetting password.

Fixes #12582

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti linked an issue Feb 4, 2026 that may be closed by this pull request
@sureshanaparti sureshanaparti added this to the 4.20.3 milestone Feb 4, 2026
@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (9ae696d) to head (1001510).

Files with missing lines Patch % Lines
...ack/api/command/SAML2LoginAPIAuthenticatorCmd.java 0.00% 6 Missing ⚠️
...loud/api/auth/DefaultLoginAPIAuthenticatorCmd.java 0.00% 3 Missing ⚠️
server/src/main/java/com/cloud/api/ApiServlet.java 0.00% 1 Missing and 1 partial ⚠️
...th2/api/command/OauthLoginAPIAuthenticatorCmd.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #12585      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
  Complexity    13428    13428              
============================================
  Files          5660     5660              
  Lines        499963   499965       +2     
  Branches      60708    60709       +1     
============================================
  Hits          81330    81330              
- Misses       409559   409562       +3     
+ Partials       9074     9073       -1     
Flag Coverage Δ
uitests 4.16% <ø> (ø)
unittests 17.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@sudo87 sudo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset password for SAML and LDAP users results in a NPE

2 participants