kvm: add ssvm storage nic null uri check during plug by shwstppr · Pull Request #11557 · apache/cloudstack

shwstppr · 2025-09-02T08:33:55Z

Description

Fixes #11552

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#11552 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

codecov · 2025-09-02T08:42:10Z

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (973b333) to head (9e2e8c9).
⚠️ Report is 4 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...cloud/hypervisor/kvm/resource/BridgeVifDriver.java	84.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11557   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
- Complexity    13287    13289    +2     
=========================================
  Files          5656     5656           
  Lines        498008   498020   +12     
  Branches      60404    60405    +1     
=========================================
+ Hits          80541    80550    +9     
- Misses       408505   408508    +3     
  Partials       8962     8962

Flag	Coverage Δ
uitests	`4.00% <ø> (-0.01%)`	⬇️
unittests	`17.02% <84.61%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland

clgtm

weizhouapache · 2025-09-02T10:01:21Z

@shwstppr
I modified the target branch to 4.20

weizhouapache

code lgtm

sureshanaparti

clgtm

DaanHoogland · 2025-09-02T13:21:04Z

@blueorangutan package

blueorangutan · 2025-09-02T13:22:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-02T14:33:29Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14819

DaanHoogland · 2025-09-02T16:17:42Z

@blueorangutan test

blueorangutan · 2025-09-02T16:20:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-03T07:57:19Z

[SF] Trillian test result (tid-14194)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53178 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11557-t14194-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2025-09-04T07:11:56Z

Refactored and added tests

@blueorangutan package

blueorangutan · 2025-09-04T07:14:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

shwstppr · 2025-09-04T07:19:33Z

The change that is causing issue #11552 went into 4.19, @weizhouapache are you okay if I rebase this to 4.19 or is that not needed considering 4.19 is EOL?

weizhouapache · 2025-09-04T07:52:14Z

The change that is causing issue #11552 went into 4.19, @weizhouapache are you okay if I rebase this to 4.19 or is that not needed considering 4.19 is EOL?

@shwstppr
I think 4.20 is good for this PR

blueorangutan · 2025-09-04T08:57:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14842

weizhouapache · 2025-09-05T18:05:36Z

@blueorangutan test

blueorangutan · 2025-09-05T18:06:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-06T10:05:52Z

[SF] Trillian test result (tid-14227)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54531 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11557-t14227-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_10_reboot_cpvm_forced	`Failure`	963.30	test_ssvm.py

weizhouapache · 2025-09-06T11:33:45Z

tested by
https://lists.apache.org/thread/8gd4179nq43lzd05h6gf6g23fq3k5yxo

daviftorres · 2025-09-08T19:14:50Z

Hey @weizhouapache , I see that this PR is in the milestone of 4.20.2 but it fixed a bug reported on 4.21.0. It is not intuitive for me. Could you please clarify how this development process works?

weizhouapache · 2025-09-08T21:27:36Z

Hey @weizhouapache , I see that this PR is in the milestone of 4.20.2 but it fixed a bug reported on 4.21.0. It is not intuitive for me. Could you please clarify how this development process works?

@daviftorres
all 4.20 commits will be merged into 4.21

weizhouapache · 2025-09-12T08:32:54Z

For those who face the issue after upgrading to 4.21.0.0

backup /usr/share/cloudstack-agent/lib/cloud-plugin-hypervisor-kvm-4.21.0.0.jar
download file
cloud-plugin-hypervisor-kvm-4.21.0.0.zip
move to /usr/share/cloudstack-agent/lib/cloud-plugin-hypervisor-kvm-4.21.0.0.jar
systemctl restart cloudstack-agent

daviftorres · 2025-09-12T14:49:13Z

It works like a charm! Good job!!

* kvm: add ssvm storage nic null uri check during plug Fixes apache#11552 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * refactor Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> --------- Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

kvm: add ssvm storage nic null uri check during plug

3680ff4

Fixes apache#11552 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg bot added the component:kvm label Sep 2, 2025

DaanHoogland approved these changes Sep 2, 2025

View reviewed changes

weizhouapache modified the milestones: 4.22.0, 4.20.2 Sep 2, 2025

weizhouapache changed the base branch from main to 4.20 September 2, 2025 10:00

weizhouapache approved these changes Sep 2, 2025

View reviewed changes

sureshanaparti approved these changes Sep 2, 2025

View reviewed changes

weizhouapache mentioned this pull request Sep 3, 2025

Agent 4.21.0.0 secondarystoragevm #11552

Closed

refactor

9e2e8c9

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

weizhouapache merged commit adec5f4 into apache:4.20 Sep 6, 2025
26 checks passed

DaanHoogland deleted the add-uricheck-storgaenicplug branch September 9, 2025 07:36

weizhouapache mentioned this pull request Sep 11, 2025

SSVM unable to create after upgrade from 4.20.1 to 4.21 #11611

Closed

weizhouapache mentioned this pull request Sep 15, 2025

Regression in 4.21.0.0 KVM agent: Storage VLAN traffic uses br<iface>-<vlan> instead of configured bridge (e.g. cloudbr2) #11634

Closed

jonathaanbastin mentioned this pull request Sep 24, 2025

Ccan only migrate off host not to it #11709

Closed

githubtonywei mentioned this pull request Oct 29, 2025

Cloudstack agent on KVM not connected after upgrade to 4.21. #11917

Open

Conversation

shwstppr commented Sep 2, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Sep 2, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Sep 2, 2025

Uh oh!

blueorangutan commented Sep 2, 2025

Uh oh!

blueorangutan commented Sep 2, 2025

Uh oh!

DaanHoogland commented Sep 2, 2025

Uh oh!

blueorangutan commented Sep 2, 2025

Uh oh!

blueorangutan commented Sep 3, 2025

Uh oh!

shwstppr commented Sep 4, 2025

Uh oh!

blueorangutan commented Sep 4, 2025

Uh oh!

shwstppr commented Sep 4, 2025

Uh oh!

weizhouapache commented Sep 4, 2025

Uh oh!

blueorangutan commented Sep 4, 2025

Uh oh!

weizhouapache commented Sep 5, 2025

Uh oh!

blueorangutan commented Sep 5, 2025

Uh oh!

blueorangutan commented Sep 6, 2025

Uh oh!

weizhouapache commented Sep 6, 2025

Uh oh!

Uh oh!

daviftorres commented Sep 8, 2025

Uh oh!

weizhouapache commented Sep 8, 2025

Uh oh!

weizhouapache commented Sep 12, 2025

Uh oh!

daviftorres commented Sep 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Sep 2, 2025 •

edited

Loading