CLOUDSTACK-9054 use of google-optional as PoC#1060
CLOUDSTACK-9054 use of google-optional as PoC#1060DaanHoogland wants to merge 1 commit intoapache:masterfrom
Conversation
c4dbcb2 to
77d1abc
Compare
|
@DaanHoogland FYI test results: Result: And: Result: These test may not cover your change, all they do is show you didn't break them. Someone else needs to review the code. |
|
tnx @remibergsma . It can be merged but more important is for it to be a coding policy so I'll link it on dev@ |
|
I would rather use Java 1.8. |
|
@rafaelweingartner we still allow for 1.7 so no 1.8 only features for now |
|
@DaanHoogland I lost track of the mailing list thread until this PR. In summary, I am -1 on the use Optional based on past experiences. Please see my response on the dev@ for a more detailed explanation. |
|
discussions to dev@ as indicated by @jburwell . this PR losts its purpose. |
this is using guave optional as suggested by @miguelaferreira in #1056. I am not convinced it is appropriate for that case (as opposed to throwing an exception) but we are going to use Optionals in someway or another. I familiar with the concept (except for in rust) and want to see if the 1.8 is different/better/worse as well.