Skip to content

[CALCITE-5596] Elasticsearch adapter test fails on Apple silicon#3122

Merged
libenchao merged 1 commit intoapache:mainfrom
coolbeevip:CALCITE-5596
Apr 24, 2023
Merged

[CALCITE-5596] Elasticsearch adapter test fails on Apple silicon#3122
libenchao merged 1 commit intoapache:mainfrom
coolbeevip:CALCITE-5596

Conversation

@coolbeevip
Copy link
Copy Markdown
Member

@coolbeevip coolbeevip commented Mar 20, 2023

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coolbeevip thanks for your contribution.
In general it looks good.
May I ask you to remove word Fix from the commit message, we tend to not use it in commit history.

@julianhyde
Copy link
Copy Markdown
Contributor

I think that 'Elasticsearch adapter test fails on Apple silicon' is a good summary for CALCITE-5596, and if you agree, that should be the commit message also.

@coolbeevip coolbeevip changed the title [CALCITE-5596] Fix Gradle test executor failed on Apple Silicon [CALCITE-5596] Elasticsearch adapter test fails on Apple silicon Mar 21, 2023
* Bump jna/testcontainers version
* Replace deprecated method getContainerIpAddress
@coolbeevip
Copy link
Copy Markdown
Member Author

Hi @julianhyde @snuyanzin

I have changed the commit message, but sonar pull request failed.

@coolbeevip coolbeevip closed this Mar 21, 2023
@coolbeevip coolbeevip reopened this Mar 21, 2023
@snuyanzin
Copy link
Copy Markdown
Contributor

Based on[1] it seems not related to the current PR changes.

    Caused by: org.sonarqube.ws.client.HttpException: Error 500 on https://sonarcloud.io/api/alm_integration/show_pullrequest?project=apache_calcite&pullrequestKey=3122 : {"errors":[{"msg":"An unexpected error occurred. Please try again later."}]}
                at org.sonarqube.ws.client.BaseResponse.failIfNotSuccessful(BaseResponse.java:22)
                at org.sonar.scanner.bootstrap.DefaultScannerWsClient.failIfUnauthorized(DefaultScannerWsClient.java:88)
                at org.sonar.scanner.bootstrap.DefaultScannerWsClient.call(DefaultScannerWsClient.java:61)

[1] https://ci-builds.apache.org/blue/organizations/jenkins/Calcite%2FCalcite-sonar/detail/PR-3122/2/artifacts

@coolbeevip coolbeevip closed this Mar 30, 2023
@coolbeevip coolbeevip reopened this Mar 30, 2023
@coolbeevip coolbeevip requested a review from snuyanzin April 23, 2023 03:40
@coolbeevip coolbeevip closed this Apr 23, 2023
@coolbeevip coolbeevip reopened this Apr 23, 2023
Copy link
Copy Markdown
Member

@libenchao libenchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me, I don't have a M1 chip mac either, could anyone with a M1 mac help to verify this?

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@coolbeevip
Copy link
Copy Markdown
Member Author

The changes looks good to me, I don't have a M1 chip mac either, could anyone with a M1 mac help to verify this?

This is the build log on my Mac M1 https://gist.github.com/coolbeevip/c276cf1aacd837ff55bf620a2452492a, Hope it will be helpful.

@libenchao
Copy link
Copy Markdown
Member

@coolbeevip Thanks for your confirmation, merging!

@libenchao libenchao merged commit 8b07457 into apache:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants