[CALCITE-5596] Elasticsearch adapter test fails on Apple silicon#3122
[CALCITE-5596] Elasticsearch adapter test fails on Apple silicon#3122libenchao merged 1 commit intoapache:mainfrom coolbeevip:CALCITE-5596
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
snuyanzin
left a comment
There was a problem hiding this comment.
@coolbeevip thanks for your contribution.
In general it looks good.
May I ask you to remove word Fix from the commit message, we tend to not use it in commit history.
|
I think that 'Elasticsearch adapter test fails on Apple silicon' is a good summary for CALCITE-5596, and if you agree, that should be the commit message also. |
* Bump jna/testcontainers version * Replace deprecated method getContainerIpAddress
|
I have changed the commit message, but sonar pull request failed. |
|
Based on[1] it seems not related to the current PR changes. |
libenchao
left a comment
There was a problem hiding this comment.
The changes looks good to me, I don't have a M1 chip mac either, could anyone with a M1 mac help to verify this?
|
Kudos, SonarCloud Quality Gate passed! |
This is the build log on my Mac M1 https://gist.github.com/coolbeevip/c276cf1aacd837ff55bf620a2452492a, Hope it will be helpful. |
|
@coolbeevip Thanks for your confirmation, merging! |








Uh oh!
There was an error while loading. Please reload this page.