Fixup mbvar convert prometheus metrics format issue (#2082)#2235
Merged
wwbmmm merged 1 commit intoapache:masterfrom Nov 7, 2023
Merged
Fixup mbvar convert prometheus metrics format issue (#2082)#2235wwbmmm merged 1 commit intoapache:masterfrom
wwbmmm merged 1 commit intoapache:masterfrom
Conversation
wwbmmm
reviewed
May 6, 2023
| *_os << "# HELP " << name << '\n' | ||
| << "# TYPE " << name << " gauge" << '\n' | ||
|
|
||
| auto get_metrics_name = [](const std::string& name) -> butil::StringPiece { |
Contributor
There was a problem hiding this comment.
这里为什么要抽出一个lambda函数呢，没看出这样做的必要性
Contributor
Author
There was a problem hiding this comment.
这个lambda函数的目的是从name中解析出metrics name，考虑到这是一个独立的小功能并且只有这个地方才会用到，所以就用了lambda。我改成普通函数吧，方便写单元测试。
Contributor
|
另外，补充一下单测吧 |
rock-git
force-pushed
the
bugfix/mbvar_prometheus
branch
from
5c7ce8e to
c23193a
Compare
Contributor
|
先合入了，单测的问题 @rock-git 有空再提PR改进一下 |
swjtu-zhanglei
added a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Apr 25, 2024
… brpc * need to update thirdparty * apache/brpc#2235
morningman
pushed a commit
to apache/doris
that referenced
this pull request
Apr 26, 2024
… brpc (#34098) * need to update thirdparty * apache/brpc#2235
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2082
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: