Skip to content

Added flag for overriding artifact hostname #36556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BCantos17 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added flag for overriding artifact hostname #36556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...java-job-service/src/main/java/org/apache/beam/runners/jobsubmission/JobServerDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ public static class ServerConfiguration {
usage = "The job service port. 0 to use a dynamic port. (Default: 8099)")
private int port = 8099;

@Option(name = "--artifact-host", usage = "The artifact service host name")
private String artifactHost = "localhost";

@Option(
name = "--artifact-port",
usage = "The artifact service port. 0 to use a dynamic port. (Default: 8098)")
Expand Down Expand Up @@ -264,7 +267,7 @@ private GrpcFnServer<ArtifactStagingService> createArtifactStagingService() thro
} else {
Endpoints.ApiServiceDescriptor descriptor =
Endpoints.ApiServiceDescriptor.newBuilder()
.setUrl(configuration.host + ":" + configuration.artifactPort)
.setUrl(configuration.artifactHost + ":" + configuration.artifactPort)
Copy link
Copy Markdown
Contributor

@damccorm damccorm May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a separate host here? This is breaking as of now, so at least it should default to the host variable

.build();
server = GrpcFnServer.create(service, descriptor, artifactServerFactory);
}
Expand Down
Loading