Skip to content

Fix PostCommit Java ValidatesRunner Samza job#31773

Merged
Abacn merged 1 commit into
apache:masterfrom
akvelon:fix-postcommit-java-samza
Jul 9, 2024
Merged

Fix PostCommit Java ValidatesRunner Samza job#31773
Abacn merged 1 commit into
apache:masterfrom
akvelon:fix-postcommit-java-samza

Conversation

@Amar3tto

@Amar3tto Amar3tto commented Jul 4, 2024

Copy link
Copy Markdown
Collaborator

Fixes #31725


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions Bot added the java label Jul 4, 2024
@Amar3tto Amar3tto marked this pull request as ready for review July 4, 2024 11:26
@Amar3tto

Amar3tto commented Jul 4, 2024

Copy link
Copy Markdown
Collaborator Author

R: @Abacn

@github-actions

github-actions Bot commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is exercises by different runner's vallidaterunner test suite. Only SamzaRunner fails. Would this change break other runners test?

Probably we just need to exclude this specific test from validateRunner target in runners/samza/build.gradle

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't break other tests (tested with DirectRunner). If we pass 0, then it searches for file.txt*.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, then it will no longer assert if the GroupintoBatches works as intended for those runners currently passing this test. Still think exclude from SamzaRunner test suite is preferred for now

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Amar3tto Amar3tto requested a review from Abacn July 6, 2024 05:19
@Amar3tto Amar3tto force-pushed the fix-postcommit-java-samza branch from 0b54b5b to 6473ccb Compare July 9, 2024 10:23
@Abacn Abacn merged commit 9721aca into apache:master Jul 9, 2024
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Java ValidatesRunner Samza job is flaky

2 participants